Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for CPUCFSQuota #187

Merged
merged 5 commits into from
Jan 31, 2023
Merged

feat: add support for CPUCFSQuota #187

merged 5 commits into from
Jan 31, 2023

Conversation

lucass4
Copy link
Contributor

@lucass4 lucass4 commented Jan 30, 2023

Addresses Feat: aws/karpenter-provider-aws#3300

Description

Add support for CpuCFSQuota.

How was this change tested?

Tested using unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucass4 lucass4 requested a review from a team as a code owner January 30, 2023 23:29
@coveralls
Copy link

coveralls commented Jan 30, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4055148503

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 79.296%
Totals Coverage Status
Change from base Build 4050137047: -0.09%
Covered Lines: 6400
Relevant Lines: 8071
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4049142580

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 79.234%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/provisioner.go 2 85.56%
pkg/controllers/provisioning/batcher.go 3 70.0%
Totals Coverage Status
Change from base Build 4048959812: -0.2%
Covered Lines: 6395
Relevant Lines: 8071
💛 - Coveralls

ellistarn
ellistarn previously approved these changes Jan 30, 2023
View reviewed changes
@ellistarn ellistarn merged commit 033f916 into kubernetes-sigs:main Jan 31, 2023
@jonathan-innis jonathan-innis mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn approved these changes

@spring1843 spring1843 Awaiting requested review from spring1843 spring1843 was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucass4 @coveralls @ellistarn @jonathan-innis