Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor Neutral CLI Flags #936

Closed
ellistarn opened this issue Dec 7, 2021 · 2 comments
Closed

Vendor Neutral CLI Flags #936

ellistarn opened this issue Dec 7, 2021 · 2 comments
Assignees
Labels
feature New feature or request neutrality

Comments

@ellistarn
Copy link
Contributor

Tell us about your request

We need some mechanism for cloud providers to attach CLI args and avoid bloating out this struct w/ every provider's flags: https://github.com/aws/karpenter/blob/main/pkg/utils/options/options.go#L29

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@ellistarn ellistarn added feature New feature or request housekeeping neutrality and removed housekeeping labels Dec 7, 2021
@mikesir87
Copy link
Contributor

One thought I've had about this... rather than using CLI flags for each of the options, would it make sense to support a YAML-based config? Then, each provider can have its own set of options, yet not have to have them exposed through the CLI directly.

@jonathan-innis
Copy link
Contributor

Closing, because we are migrating configuration to the karpenter-global-settings ConfigMap starting with #2746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request neutrality
Projects
None yet
Development

No branches or pull requests

3 participants