BREAKING CHANGE: Migrate AWS Settings from CLI Args to ConfigMap #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
jonathan-innis
force-pushed
the
migrate-aws-settings
branch
19 times, most recently
from
9b08487 to
3cbb262
Compare
jonathan-innis
changed the title
jonathan-innis
force-pushed
the
migrate-aws-settings
branch
3 times, most recently
from
bb5ce2c to
5a83276
Compare
ellistarn
reviewed
Oct 31, 2022
ellistarn
reviewed
Oct 31, 2022
jonathan-innis
force-pushed
the
migrate-aws-settings
branch
from
5a83276 to
322eb99
Compare
jonathan-innis
force-pushed
the
migrate-aws-settings
branch
4 times, most recently
from
6a04f46 to
ac5e28d
Compare
jonathan-innis
force-pushed
the
migrate-aws-settings
branch
3 times, most recently
from
89f1436 to
e73f0b2
Compare
jonathan-innis
force-pushed
the
migrate-aws-settings
branch
from
e73f0b2 to
db0f2b3
Compare
ellistarn
previously approved these changes
Nov 3, 2022
jonathan-innis
force-pushed
the
migrate-aws-settings
branch
from
db0f2b3 to
9bdbb72
Compare
jonathan-innis
force-pushed
the
migrate-aws-settings
branch
from
9bdbb72 to
24f7c11
Compare
jonathan-innis
force-pushed
the
migrate-aws-settings
branch
from
24f7c11 to
1a8e458
Compare
bwagner5
changed the title
This was referenced Nov 7, 2022
3 tasks
andskli
added a commit
to aws-samples/cdk-eks-karpenter
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Integrating this new code will break customers who were using these CLI args
Fixes #
Description
awsettings.FromContext(ctx)This is the buddy PR for
karpenter-core: kubernetes-sigs/karpenter#39How was this change tested?
make battletestFOCUS=Integration make e2etestsDoes this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.