Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: karpenter-global-settings migration #4789

Merged
merged 4 commits into from
Oct 19, 2023
Merged

chore: karpenter-global-settings migration #4789

merged 4 commits into from
Oct 19, 2023

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Oct 10, 2023 •
edited
Loading

Fixes #N/A

Description
This PR is the first step in removing the karpenter-global-settings configmap as part of v1beta1. It adds the additional fields to the cli flags / env vars, but does not remove the configmap. Currently both are supported, but values set by cli flags / env vars will take precedent.

How was this change tested?
karpenter snapshot + manual testing

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 006f7f5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6531baeef5a7ec00083e79b3
😎 Deploy Preview https://deploy-preview-4789--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jmdeal jmdeal force-pushed the karpenter-core-settings-migration branch 4 times, most recently from ee4aef9 to 71a512c Compare October 11, 2023 16:48
jmdeal
jmdeal commented Oct 11, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@jmdeal jmdeal force-pushed the karpenter-core-settings-migration branch 2 times, most recently from 361adc4 to c1fbd71 Compare October 11, 2023 21:47
jmdeal
jmdeal commented Oct 11, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-c1fbd715f39245f7d9aa828f083d3aaff8316537.

@jmdeal jmdeal mentioned this pull request Oct 12, 2023
Merged
@jmdeal jmdeal marked this pull request as ready for review October 12, 2023 17:18
@jmdeal jmdeal requested a review from a team as a code owner October 12, 2023 17:18
@jmdeal jmdeal requested a review from ellistarn October 12, 2023 17:18
jmdeal
jmdeal commented Oct 12, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@jmdeal jmdeal force-pushed the karpenter-core-settings-migration branch from db49417 to f3565d6 Compare October 12, 2023 17:37
jmdeal
jmdeal commented Oct 12, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-f3565d639e1556b6b233995cde6dd8d80e6434cb.

jmdeal
jmdeal commented Oct 12, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-414a6b1fa3ec327aebefd46939f72b29ffb56a55.

@jmdeal jmdeal mentioned this pull request Oct 12, 2023
Merged
3 tasks
@jmdeal jmdeal force-pushed the karpenter-core-settings-migration branch from 37a6b8f to adb29ff Compare October 13, 2023 01:31
jmdeal
jmdeal commented Oct 13, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-adb29ffbb44f76fb9147e7d07b78e8a0845864ba.

@jmdeal jmdeal force-pushed the karpenter-core-settings-migration branch 2 times, most recently from a62e714 to d93ca48 Compare October 13, 2023 03:37
jmdeal
jmdeal commented Oct 13, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-d93ca48ca820600e0a025d831e2ffdf7355a095f.

@jmdeal jmdeal force-pushed the karpenter-core-settings-migration branch 2 times, most recently from 461f73e to 20f2c0e Compare October 14, 2023 00:15
@jmdeal jmdeal force-pushed the karpenter-core-settings-migration branch 2 times, most recently from 06c3438 to 4c3d166 Compare October 19, 2023 17:23
@jmdeal jmdeal force-pushed the karpenter-core-settings-migration branch 2 times, most recently from 7067d04 to 91eeb7f Compare October 19, 2023 18:44
jonathan-innis
jonathan-innis previously approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

jmdeal
jmdeal commented Oct 19, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis previously approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-d85cd50fbbbe0d28aff84c81c8de22305f571390.

@jmdeal jmdeal force-pushed the karpenter-core-settings-migration branch from d85cd50 to 0de6ba7 Compare October 19, 2023 20:46
jmdeal
jmdeal commented Oct 19, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-0de6ba74f8934d0bf1859abcfbbbe7999b84dd0a.

@jmdeal jmdeal force-pushed the karpenter-core-settings-migration branch from 0de6ba7 to 006f7f5 Compare October 19, 2023 23:25
@jmdeal jmdeal enabled auto-merge (squash) October 19, 2023 23:32
jonathan-innis
jonathan-innis approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 8c33a40 into aws:main Oct 19, 2023
10 checks passed
@jmdeal jmdeal deleted the karpenter-core-settings-migration branch October 20, 2023 18:29
@jmdeal jmdeal restored the karpenter-core-settings-migration branch October 20, 2023 18:29
@jmdeal jmdeal mentioned this pull request Oct 30, 2023
Closed
3 tasks
@jmdeal jmdeal linked an issue Oct 30, 2023 that may be closed by this pull request
Environment Variable Substitution or CLI Flags #2893
Closed
@ellistarn ellistarn mentioned this pull request Oct 13, 2023
Closed
@jmdeal jmdeal deleted the karpenter-core-settings-migration branch December 4, 2023 20:34
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
@jmdeal @johngmyers
chore: karpenter-global-settings migration (aws#4789)
32a19d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@ellistarn ellistarn Awaiting requested review from ellistarn ellistarn is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment Variable Substitution or CLI Flags
2 participants
@jmdeal @jonathan-innis