Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use cleanup input in GHA on workflow_dispatch #4942

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Oct 26, 2023

Fixes #N/A

Description

Ensure that the inputs.cleanup value is used assuming that the job is kicked-off by a workflow_dispatch

This PR also fixes the E2ECleanup workflow by ensuring that we are checking out the repo before calling a composite action

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 26, 2023 21:47
@jonathan-innis jonathan-innis requested a review from tzneal October 26, 2023 21:47
@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit a2b171f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/653adfebfe0e5d0007388a51

@jonathan-innis jonathan-innis force-pushed the use-cleanup-input branch 2 times, most recently from fc4abed to 9c0e335 Compare October 26, 2023 21:50
@jonathan-innis jonathan-innis enabled auto-merge (squash) October 26, 2023 21:50
@jonathan-innis jonathan-innis changed the title ci: Use cleanup input ci: Use cleanup input in GHA Oct 26, 2023
@jonathan-innis jonathan-innis changed the title ci: Use cleanup input in GHA ci: Use cleanup input in GHA on workflow_dispatch Oct 26, 2023
engedaam
engedaam previously approved these changes Oct 26, 2023
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 81d3262 into aws:main Oct 26, 2023
11 checks passed
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants