Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove e2e install helm action for release.yaml #4972

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This removes the install-helm action from the release.yaml to ensure that we don't get a dirty commit

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 30, 2023 23:26
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) October 30, 2023 23:29
@jonathan-innis jonathan-innis merged commit 5dde272 into aws:release-v0.31.x Oct 30, 2023
9 checks passed
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
…stream release-v0.31.2

Merge in DEL/karpenter-fork from IENGOC-199 to main

* commit '3535354df38803b3b6b40cd7efcaecfbd93a4d48': (270 commits)
  Stable Release updates Release v0.31.2.
  ci: Pin helm version for `release.yaml` (aws#4974)
  ci: Remove e2e install helm action for `release.yaml` (aws#4972)
  Bump karpenter-core to latest
  fix: Handle rollback to earlier version of Karpenter (aws#4830)
  chore(deps): bump google.golang.org/grpc from 1.55.0 to 1.56.3 in /tools/allocatable-diff (aws#4930)
  chore(deps): bump google.golang.org/grpc from 1.58.2 to 1.58.3 (aws#4928)
  Pin helm version to v3.12.3 due to ECR push bug
  ci: Call composite action with values (aws#4767)
  ci: Pin helm version in action due to `v3.13.0` bug (aws#4762)
  Add debug to helm push
  Add permission in release workflow for GH release generation
  Bump karpenter-core for v0.31.1 release
  fix: use inputs for composite action (aws#4753)
  fix: id-token permission for release / snapshot (aws#4752)
  fix: add checkout to snapshot / release workflows (aws#4751)
  test: move snapshot releases to separate ECR repo (aws#4734)
  chore: update aws role to GithubRelease (aws#4743)
  test: allow updating env for ds with multiple containers (aws#4706)
  ci: Fix passing through the `event_name` correctly (aws#4719)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants