Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove alpha e2es #5011

Merged
merged 2 commits into from
Nov 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions .github/actions/e2e/create-cluster/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,23 +55,6 @@ runs:
--capabilities CAPABILITY_NAMED_IAM \
--parameter-overrides "ClusterName=${{ inputs.cluster_name }}" \
--tags "testing/type=e2e" "testing/cluster=${{ inputs.cluster_name }}" "github.com/run-url=https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" "karpenter.sh/discovery=${{ inputs.cluster_name }}"
- name: deploy alpha instance profile
shell: bash
run: |
aws iam create-instance-profile --instance-profile-name "KarpenterNodeInstanceProfile-${{ inputs.cluster_name }}" --tags Key=testing/type,Value=e2e Key=testing/cluster,Value=${{ inputs.cluster_name }} || true
aws iam add-role-to-instance-profile --instance-profile-name "KarpenterNodeInstanceProfile-${{ inputs.cluster_name }}" --role-name "KarpenterNodeRole-${{ inputs.cluster_name }}" || true
- name: deploy alpha policy
shell: bash
run: |
export AWS_PARTITION=aws
export AWS_REGION=${{ inputs.region }}
export AWS_ACCOUNT_ID=${{ inputs.account_id }}
export CLUSTER_NAME=${{ inputs.cluster_name }}

POLICY_DOCUMENT=$(envsubst < .github/actions/e2e/create-cluster/alpha-controller-policy.json)
POLICY_NAME="KarpenterControllerPolicy-Alpha-${CLUSTER_NAME}"
echo "Creating policy $POLICY_NAME..."
aws iam create-policy --policy-name "$POLICY_NAME" --policy-document "$POLICY_DOCUMENT" || true
- name: create or upgrade cluster
shell: bash
run: |
Expand Down Expand Up @@ -119,7 +102,6 @@ runs:
namespace: karpenter
attachPolicyARNs:
- "arn:aws:iam::${{ inputs.account_id }}:policy/KarpenterControllerPolicy-${{ inputs.cluster_name }}"
- "arn:aws:iam::${{ inputs.account_id }}:policy/KarpenterControllerPolicy-Alpha-${{ inputs.cluster_name }}"
permissionsBoundary: "arn:aws:iam::${{ inputs.account_id }}:policy/GithubActionsPermissionsBoundary"
roleName: karpenter-irsa-${{ inputs.cluster_name }}
roleOnly: true
Expand All @@ -144,9 +126,9 @@ runs:
wellKnownPolicies:
ebsCSIController: true
EOF

eksctl ${cmd} cluster -f clusterconfig.yaml

# We need to call these update iamserviceaccount commands again since the "eksctl upgrade cluster" action
# doesn't handle updates to IAM serviceaccounts correctly when the roles assigned to them change
eksctl update iamserviceaccount -f clusterconfig.yaml --approve
Expand Down
166 changes: 0 additions & 166 deletions .github/actions/e2e/create-cluster/alpha-controller-policy.json

This file was deleted.

44 changes: 0 additions & 44 deletions .github/workflows/alpha-e2e-scale-trigger.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/approval-comment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:

jobs:
approval-comment:
if: startsWith(github.event.review.body, '/karpenter snapshot') || startsWith(github.event.review.body, '/karpenter alpha-scale') || startsWith(github.event.review.body, '/karpenter scale') || startsWith(github.event.review.body, '/karpenter versionCompatibility')
if: startsWith(github.event.review.body, '/karpenter snapshot') || startsWith(github.event.review.body, '/karpenter scale') || startsWith(github.event.review.body, '/karpenter versionCompatibility')
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-cleanup.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ jobs:
region: ${{ inputs.region }}
cluster_name: ${{ inputs.cluster_name }}
git_ref: ${{ inputs.git_ref }}
eksctl_version: v0.164.0
eksctl_version: v0.164.0
2 changes: 1 addition & 1 deletion .github/workflows/e2e-matrix-trigger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ jobs:
# Default to true unless using a workflow_dispatch
cleanup: ${{ github.event_name != 'workflow_dispatch' && true || inputs.cleanup }}
secrets:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
8 changes: 0 additions & 8 deletions .github/workflows/e2e-matrix.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,6 @@ jobs:
- Beta/Expiration
- Beta/Chaos
- Beta/IPv6
- Alpha/Integration
- Alpha/Machine
- Alpha/Consolidation
- Alpha/Interruption
- Alpha/Drift
- Alpha/Expiration
- Alpha/Chaos
- Alpha/IPv6
uses: ./.github/workflows/e2e.yaml
with:
suite: ${{ matrix.suite }}
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,6 @@ on:
- Beta/Chaos
- Beta/IPv6
- Beta/Scale
- Alpha/Integration
- Alpha/Machine
- Alpha/Consolidation
- Alpha/Utilization
- Alpha/Interruption
- Alpha/Drift
- Alpha/Expiration
- Alpha/Chaos
- Alpha/IPv6
- Alpha/Scale
k8s_version:
type: choice
options:
Expand Down
Loading