Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note about deprecated label support #5198

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Nov 30, 2023

Fixes #5194

Description
Adds a note in the docs that Karpenter supports several deprecated labels, translating them to their stable counterparts under the hood.

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner November 30, 2023 22:53
@jmdeal jmdeal requested a review from engedaam November 30, 2023 22:53
Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 30b2cb1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65691956c835790008bf0b0b
😎 Deploy Preview https://deploy-preview-5198--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jmdeal jmdeal changed the title update docs to call out depracated label support docs: note about deprecated label support Nov 30, 2023
@jmdeal jmdeal force-pushed the docs-pv-suppoted-topology-labels branch from ff35826 to 5fbe13c Compare November 30, 2023 22:55
@jmdeal jmdeal force-pushed the docs-pv-suppoted-topology-labels branch from 5fbe13c to 30b2cb1 Compare November 30, 2023 23:23
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 4ea4808 into aws:main Dec 1, 2023
12 checks passed
@jmdeal jmdeal deleted the docs-pv-suppoted-topology-labels branch December 4, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for Nodeaffinity Key "failure-domain.beta.kubernetes.io/zone" in karpenter schedule logic.
2 participants