Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update Karpenter commit used for upgrade testing #6881

Merged
merged 1 commit into from
Aug 27, 2024
Merged

ci: Update Karpenter commit used for upgrade testing #6881

merged 1 commit into from
Aug 27, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Bump commit to use a commit that lives in the snapshot repo

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner August 27, 2024 19:12
@engedaam engedaam requested a review from tzneal August 27, 2024 19:12
@netlify Netlify
Copy link

netlify bot commented Aug 27, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit a430bca
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66ce250ec1f0890008e3e44a
😎 Deploy Preview https://deploy-preview-6881--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jigisha620
jigisha620 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam enabled auto-merge (squash) August 27, 2024 19:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10584386005

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 79.311%
Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 10569590680: -0.03%
Covered Lines: 5938
Relevant Lines: 7487
💛 - Coveralls

@engedaam engedaam merged commit 30853fe into aws:main Aug 27, 2024
16 checks passed
@engedaam engedaam deleted the bump-karpenter-commit branch October 30, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jigisha620 jigisha620 jigisha620 approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jigisha620