Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix e2e test matrix script syntax #6992

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

bryantbiggs
Copy link
Member

Fixes #N/A
image

Description

  • Fix e2e test matrix script syntax

How was this change tested?

You can reproduce locally with the following:

Current, throws error:

#!/bin/bash

if (( "$PRIVATE_CLUSTER" == 'true' )); then
  echo "Private cluster is enabled"
else
  echo "Private cluster is disabled"
fi

Fixed, no error:

#!/bin/bash

if (( "$PRIVATE_CLUSTER" == "true" )); then
  echo "Private cluster is enabled"
else
  echo "Private cluster is disabled"
fi

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bryantbiggs bryantbiggs requested a review from a team as a code owner September 12, 2024 18:05
@bryantbiggs bryantbiggs requested a review from rschalo September 12, 2024 18:05
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4280e83
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66e342111df36f00088463d4

@coveralls
Copy link

coveralls commented Sep 12, 2024

Pull Request Test Coverage Report for Build 10837539736

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.025%

Totals Coverage Status
Change from base Build 10837327997: 0.0%
Covered Lines: 5512
Relevant Lines: 6639

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 322b92a into aws:main Sep 12, 2024
26 checks passed
@bryantbiggs bryantbiggs deleted the fix/e2e-test-script branch September 12, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants