Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update getting started guide nodepool to use od #7023

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Sep 16, 2024

Fixes #N/A

Description
Updates the getting started guide nodepool to use od, to ensure users can test without having to worry about spot capacity

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner September 16, 2024 21:35
@njtran njtran requested a review from danxwang22 September 16, 2024 21:35
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 0bcdcb3
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66e8a4be4698480008de02c9
😎 Deploy Preview https://deploy-preview-7023--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran enabled auto-merge (squash) September 16, 2024 21:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10892417104

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.025%

Totals Coverage Status
Change from base Build 10891564163: 0.0%
Covered Lines: 5512
Relevant Lines: 6639

💛 - Coveralls

@njtran njtran merged commit 9beb56f into aws:main Sep 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants