Indirectly support the searching of certificates and private keys in local machine certificate stores #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13ajay
force-pushed
the
feature/RolesAnywhere-4906
branch
from
7c38b2c
to
292ecec
Compare
local machine certificate stores * Support the passing in of arbitrary names for system certificate stores when leveraging the Windows certificate store integration. * Note that while the stores are still opened within the CERT_SYSTEM_STORE_CURRENT_USER context, "all current user certificate stores except the Current User/Personal store inherit the contents of local machine certificate stores." This means that certificates and private keys added to local machine certificate stores can still be accessed through the credential helper. * Do a case-insensitive comparison of the system store name passed in with the predefined system store names (as defined in the Microsoft documentation). If there is a match, canonicalize the case so that it can be used to open a valid system certificate store. Otherwise, use the provided name (assuming that the user has created a custom certificate store with that name).
13ajay
force-pushed
the
feature/RolesAnywhere-4906
branch
from
292ecec
to
a537775
Compare
rlalcorn
approved these changes
Oct 11, 2023
* Change wording used in one sentence in the README. * Enforce mutual exclusion a bit better between PKCS#11 flags, certificate store flags, and file system flags.
13ajay
force-pushed
the
feature/RolesAnywhere-4906
branch
from
6322c01
to
ba68307
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #41
Description of changes:
Support the passing in of arbitrary names for system certificate stores when leveraging the Windows certificate store integration.
Note that while the stores are still opened within the CERT_SYSTEM_STORE_CURRENT_USER context, "all current user certificate stores except the Current User/Personal store inherit the contents of local machine certificate stores." This means that certificates and private keys added to local machine certificate stores can still be accessed through the credential helper.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.