fix(s2n-quic-xdp): correct tokio feature dependency #1808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We are currently unable to publish to crates.io because
s2n-quic-xdp
can't be published. This is becauses2n-quic-xdp
depends on thenet
feature, but we forgot to specify that in the Cargo.toml.Previously the
s2n-quic-xdp
crate was using the default feature resolver, which unified features across normal and dev dependencies, so the build pulled infull
tokio features because tokio-full is a dev dependency.Publishing crates uses a different feature resolver that doesn't pull in dev-dependencies, so the build failed because our build had a dependency on the
net
feature of tokio that wasn't fully modeled in theCargo.toml
This PR
tokio
net
feature.Edit: The section previously talked about how it would be difficult to write a check for this with
cargo publish --dry-run
but thefeature-resolver = 2
should allow us to correctly test for this failure in CI.Testing:
This was verified with the following command
This failed before the change, and now succeeds.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.