Optimize path secret Entry size #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
previously approved these changes
Sep 25, 2024
|
Oh looks like we have a failing check where we're asserting the size of the entry: https://github.com/aws/s2n-quic/actions/runs/10998636381/job/30537103568?pr=2329#step:11:894 |
Mark-Simulacrum
force-pushed
the
sizing-path-secrets
branch
7 times, most recently
from
764e82f to
4d96f3e
Compare
This shrinks the Entry state by ~700 bytes.
Mark-Simulacrum
force-pushed
the
sizing-path-secrets
branch
2 times, most recently
from
86ca7e7 to
6c8ae05
Compare
camshaft
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds a custom SizeOf trait and implements it for the types contained in a given Entry, and adds a GHA CI-only test that checks the size of the entry is as we expect. It's likely that we will want to change this but this is an initial proposal of how to do that without breaking downstream consumers.
We also add a benchmark for hmac init (locally I get 200-600ns depending on key type) and removes the OnceCell cache as part of Entry, bringing us down to ~300 bytes.
Testing:
See added test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.