core: update github PR template #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesleyRosenblum
previously approved these changes
Nov 12, 2024
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -1,10 +1,13 @@ | |||
| ### Release Summary: | |||
| <!-- If this is a feature or bug that impacts customers and is significant enough to include in the "Summary" section of the next version release, please include a brief (1-2 sentences) description of the change. The audience of this summary is future customers, not maintainers or reviewers. See https://github.com/aws/s2n-tls/releases/tag/v1.5.7 for an example. Otherwise, leave this section blank --> | |||
There was a problem hiding this comment.
I'd probably point this to an s2n-quic example once we have one
There was a problem hiding this comment.
Agreed, we just don't have one yet 🙃
Co-authored-by: Wesley Rosenblum <55108558+WesleyRosenblum@users.noreply.github.com>
WesleyRosenblum
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
s2n-quic version of aws/s2n-tls#4885
Call-outs:
I wasn't sure what testing I could list under "Testing" the way I listed testing requirements for s2n-tls. The unit tests requirement hold true, but I'm not sure about the others. Suggestions? That could also just be a separate PR from someone more familiar with s2n-quic tests.
Testing:
documentation change
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.