feat(s2n-quic): improve local handshake failure visibility #2383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change includes a few additions that will better assist in debugging handshake failures:
s2n-tls
provider, it includes theerror.message()
as thereason
, which is much more descriptive than a genericHANDSHAKE_FAILURE
connection::Error::from
instead ofInto::into
which has issues with passing on the#[track_caller]
informationCONNECTION_CLOSE
formatter provider as an unstable feature, which allows for more descriptive errors to be sent over the wire, if desired. This option comes with the warning outlined in the docs: https://docs.rs/s2n-quic-core/latest/s2n_quic_core/connection/close/struct.Development.htmlBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.