Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s2n-quic): improve local handshake failure visibility #2383

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

camshaft
Copy link
Contributor

@camshaft camshaft commented Nov 20, 2024

Description of changes:

This change includes a few additions that will better assist in debugging handshake failures:

  • For the s2n-tls provider, it includes the error.message() as the reason, which is much more descriptive than a generic HANDSHAKE_FAILURE
  • It uses connection::Error::from instead of Into::into which has issues with passing on the #[track_caller] information
  • Finally, it exposes the CONNECTION_CLOSE formatter provider as an unstable feature, which allows for more descriptive errors to be sent over the wire, if desired. This option comes with the warning outlined in the docs: https://docs.rs/s2n-quic-core/latest/s2n_quic_core/connection/close/struct.Development.html

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@camshaft camshaft marked this pull request as ready for review November 20, 2024 21:28
@camshaft camshaft merged commit d8fe405 into main Nov 21, 2024
132 checks passed
@camshaft camshaft deleted the camshaft/handshake-failure-error branch November 21, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants