Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log predict time properly #27

Merged
merged 2 commits into from
Aug 23, 2021
Merged

log predict time properly #27

merged 2 commits into from
Aug 23, 2021

Conversation

dzorlu
Copy link

@dzorlu dzorlu commented Aug 20, 2021 •
edited
Loading

Description of changes:
Calculate predict time correctly.

Handler service logs elapsed times for each component but there as below where predict time is not captured correctly.

Screen Shot 2021-08-19 at 5 23 12 PM

With the change, the log output would be like:
Screen Shot 2021-08-20 at 11 24 35 AM

philschmid
philschmid approved these changes Aug 23, 2021
View reviewed changes
Copy link
Collaborator

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also adjusted the postprocess_time since it would have been wrong after the changes

@philschmid philschmid merged commit 2fb97f9 into aws:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philschmid philschmid philschmid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzorlu @philschmid