change: add release buildspec #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buildspec-release.yml
Outdated
| "dest": ["'$FRAMEWORK_FULL_VERSION'-gpu-py3", "'$FRAMEWORK_SHORT_VERSION'-gpu-py3", "'$FRAMEWORK_FULL_VERSION'-gpu-py3-'${CODEBUILD_BUILD_ID#*:}'"] | ||
| }], | ||
| "test": [ | ||
| "IGNORE_COVERAGE=- tox -e py36 -- test/integration/sagemaker/test_hosting.py --py-version 3 --processor cpu --region {region} --docker-base-name '$ECR_REPO' --aws-id 520713654638 --framework-version '$FRAMEWORK_FULL_VERSION'", |
There was a problem hiding this comment.
We should use the current account id since not all the prod images are in 520713654638 anymore
scripts/build_all.py
Outdated
|
|
||
| # Run docker-login so we can pull the cached image | ||
| login_cmd = subprocess.check_output( | ||
| 'aws ecr get-login --no-include-email --registry-id {}'.format(args.account).split()) |
There was a problem hiding this comment.
do we need the --region here for the special regions?
There was a problem hiding this comment.
this will only be run in the region where it's being built, which in our case is us-west-2, but I guess it doesn't hurt to add it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Following in the footsteps of the other packages: this PR adds a buildspec for CodeBuild to use to release images.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.