Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Huggingface glue failing tests #4367

Merged
merged 13 commits into from
Jan 11, 2024
2 changes: 1 addition & 1 deletion doc/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
}

# Example configuration for intersphinx: refer to the Python standard library.
intersphinx_mapping = {"http://docs.python.org/": None}
intersphinx_mapping = {"python": ("http://docs.python.org/", None)}

# -- Options for autodoc ----------------------------------------------------
# https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#configuration
Expand Down
2 changes: 1 addition & 1 deletion doc/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
sphinx==3.1.2
sphinx==3.4.3
sphinx-rtd-theme==0.5.0
docutils==0.15.2
packaging==20.9
Expand Down
12 changes: 5 additions & 7 deletions src/sagemaker/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -4565,20 +4565,18 @@ def update_inference_component(
Args:
inference_component_name (str): Name of the Amazon SageMaker ``InferenceComponent``.
specification ([dict[str,int]]): Resource configuration. Optional.
Example: {
Example: {
"MinMemoryRequiredInMb": 1024,
"NumberOfCpuCoresRequired": 1,
"NumberOfAcceleratorDevicesRequired": 1,
"MaxMemoryRequiredInMb": 4096,
},
},
runtime_config ([dict[str,int]]): Number of copies. Optional.
Default: {
Default: {
"copyCount": 1
}
}
wait: Wait for inference component to be created before return. Optional. Default is
True.
True.
Return:
str: inference component name
Expand Down
1 change: 1 addition & 0 deletions tests/data/huggingface/requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
datasets==2.16.1
2 changes: 1 addition & 1 deletion tests/data/huggingface_byoc/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
transformers<=4.28.1
datasets<=2.12.0
datasets==2.16.1
3 changes: 2 additions & 1 deletion tests/integ/test_huggingface.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ def test_huggingface_training(

hf = HuggingFace(
py_version=huggingface_pytorch_latest_training_py_version,
entry_point=os.path.join(data_path, "run_glue.py"),
source_dir=data_path,
entry_point="run_glue.py",
role="SageMakerRole",
transformers_version=huggingface_training_latest_version,
pytorch_version=huggingface_training_pytorch_latest_version,
Expand Down
4 changes: 2 additions & 2 deletions tests/integ/test_huggingface_torch_distributed.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ def test_huggingface_torch_distributed_g5_glue(
huggingface_pytorch_latest_training_py_version,
):
with timeout.timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
data_path = os.path.join(DATA_DIR, "huggingface")
estimator = HuggingFace(
py_version=huggingface_pytorch_latest_training_py_version,
entry_point=os.path.join(data_path, "run_glue.py"),
source_dir=os.path.join(DATA_DIR, "huggingface"),
entry_point="run_glue.py",
role="SageMakerRole",
transformers_version=huggingface_training_latest_version,
pytorch_version=huggingface_training_pytorch_latest_version,
Expand Down