Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add TensorFlow 2.14 image configs #4446

Merged
merged 1 commit into from
Mar 1, 2024
Merged

feature: Add TensorFlow 2.14 image configs #4446

merged 1 commit into from
Mar 1, 2024

Conversation

saimidu
Copy link
Contributor

@saimidu saimidu commented Feb 22, 2024 •
edited
Loading

Issue #, if available:

Description of changes:
Add TensorFlow 2.14.1 to tensorflow.json in image_uri_configs to enable TF training and inference using the SDK

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@saimidu saimidu requested a review from a team as a code owner February 22, 2024 19:57
@saimidu saimidu requested review from mufaddal-rohawala and removed request for a team February 22, 2024 19:57
@knikure knikure self-assigned this Feb 22, 2024
@knikure knikure added the do-not-merge Use when PR needs to be marked as do not merge label Feb 22, 2024
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 8e982e4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 8e982e4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 8e982e4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 8e982e4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.16%. Comparing base (8b206ba) to head (4df06c3).
Report is 49 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4446      +/-   ##
==========================================
+ Coverage   86.94%   87.16%   +0.22%     
==========================================
  Files        1203      387     -816     
  Lines      107211    35811   -71400     
==========================================
- Hits        93211    31215   -61996     
+ Misses      14000     4596    -9404

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 8e982e4
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4df06c3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4df06c3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4df06c3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4df06c3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 4df06c3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure removed the do-not-merge Use when PR needs to be marked as do not merge label Feb 29, 2024
knikure
knikure reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@knikure knikure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr, unit-tests

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4df06c3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4df06c3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure merged commit 7d6f220 into aws:master Mar 1, 2024
8 checks passed
@saimidu saimidu deleted the add_tf_2.14 branch March 6, 2024 02:46
bencrabtree pushed a commit to bencrabtree/sagemaker-python-sdk that referenced this pull request Mar 13, 2024
@saimidu @bencrabtree
feature: Add TensorFlow 2.14 image configs (aws#4446)
b4a726f
benieric added a commit that referenced this pull request Mar 15, 2024
@bencrabtree @nikhil-sk
@qidewenwhen @repushko @saimidu @rohangujarathi @can-sun @jmahlik @evakravi @knikure @gverkes @akrishna1995 @samruds @adtian2 @sirutBuasai @dbushy727 @benieric @xiongz945 @martinRenou @mrudulmn @Captainia @liujiaorr @jinyoung-lim @shinglyu @makungaj1 @stacicho @tonyhoo
Feat/rebase master (#4498)
d820b28 
* prepare release v2.210.0

* update development version to v2.210.1.dev0

* feat: Add new Triton DLC URIs (#4432)

* Add new Triton DLC URIs

* Update according to black and pylint

* feat: Support selective pipeline execution between function step and regular step (#4392)

* feat: Add AutoMLV2 support (#4461)

* Add AutoMLV2 support

* Improvements of the integration tests

---------

Co-authored-by: Anton Repushko <repuanto@amazon.com>

* feature: Add TensorFlow 2.14 image configs (#4446)

* fix: remove enable_network_isolation from the python doc (#4465)

Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>

* doc: Add doc for new feature processor APIs and classes (#4250)

* fix: properly close sagemaker config file after loading config (#4457)

Closes #4456

* feat: instance specific jumpstart host requirements (#4397)

* feat: instance specific jumpstart host requirements

* chore: add js support for copies resource requirement, enforce coupling with ResourceRequirements class

* fix: typing

* fix: pylint

* change: Bump Apache Airflow version to 2.8.2 (#4470)

* Update tox.ini

* Update test_requirements.txt

* fix: make sure gpus are found in local_gpu run (#4384)

* fix: make sure gpus are found in local_gpu run

* fix: black formatting

* fix: adjust unit test

* feat: pin dll version to support python3.11 to the sdk (#4472)

Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>

* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)

* prepare release v2.211.0

* update development version to v2.211.1.dev0

* change: Enhance model builder selection logic to include model size (#4429)

* change: Enhance model builder selection logic to include model size

* Fix conflicts

* Address PR comments

* fix formatting

* fix formatting of test

* Fix token in tasks.json

* Increase coverage for tests

* fix formatting

* Fix requirements

* Import code instead of importing accelerate

* Fix formatting

* Setup dependencies

* change: Upgrade smp to version 2.2 (#4479)

* upgrading smp to version 2.2

* fixing linting issue

* fixing syntax error with multiline if statement

* upgrading smp to version 2.2

* fixing linting issue

* fixing syntax error with multiline if statement

* fixing formatting

---------

Co-authored-by: Andrew Tian <tinandr@amazon.com>

* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)

* update pt2.2 sm training dlc pysdk

* update pt2.2 sm inference dlc pysdk and region list

* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)

* fix: Create custom tarfile extractall util to fix backward compatibility issue

* Address review comments

* fix logger.error statements

* prepare release v2.212.0

* update development version to v2.212.1.dev0

* change: Update tblib constraint (#4452)

* fix: make unit tests compatible with pytest-xdist (#4486)

* fix: make unit tests compatible with pytest-xdist

* fix failing test

* feature: Add overriding logic in ModelBuilder when task is provided (#4460)

* feat: Add Optional task to Model

* Revert "feat: Add Optional task to Model"

This reverts commit fd3e86b.

* Add override logic in ModelBuilder with task provided

* Adjusted formatting

* Add extra unit tests for invalid inputs

* Address PR comments

* Add more test inputs to integration test

* Add model_metadata field to ModelBuilder

* Update doc

* Update doc

* Adjust formatting

---------

Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>

* feature: Accept user-defined env variables for the entry-point (#4175)

* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)

* change: enable github actions for PRs (#4489)

* change: enable github actions for PRs

* Update codebuild-ci.yml

* trigger on pull_request_target

* add source-version-override

* fix permission

* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)

Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>

* feat: support JumpStart proprietary models (#4467)

* feat: add proprietary manifest/specs parsing

add unittests for test_cache

small refactoring

address comments and more unittests

fix linting and fix more tests

fix: pylint

feat: JumpStartModel class for prop models

* remove unused imports and fix docstyle

* fix: remove unused args

* fix: remove unused args

* fix: more unused vars

* fix: slow tests

* fix: unittests

* added more tests to cover some lines

* remove estimator warn check

* chore: address comments re performance

* fix: address comments

* complete list experience and other fixes

* fix: pylint

* add doc utils and fix pylint

* fix: docstyle

* fix: doc

* fix: default payloads

* fix: doc and tags and enums

* fix: jumpstart doc

* rename to open_weights and fix filtering

* update filter name

* doc update

* fix: black

* rename to proprietary model and fix unittests

* address comments

* fix: docstyle and flake8

* address more comments and fix doc

* put back doc utils for future refactoring

* add prop model title in doc

* doc update

---------

Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>

* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)

* fix: raise exception when no instance specific gated training env var available

* chore: raise client exception if accept_eula flag is not set for gated models

* chore: address flake8 errors

* chore: emit warning when instance type is chosen with no gated training artifacts

* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) (#4423)

* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421)

* change: bump jinja2 to 3.1.3 in doc/requirments.txt

* Update requirements.txt

* feature: TGI 1.4.0 (#4424)

* documentation: fix the ClarifyCheckStep documentation to mention PDP (#4259)

* documentation: fix the ClarifyCheckStep documentation to mention PDP support

* fix: break the lines to meet pylint requirement

---------

Co-authored-by: Shing Lyu <shinglyu@amazon.nl>

* documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (#4261)

* documentation: explain the ClarifyCheckStep and QualityCheckStep parameters

* fix: remove trailing space

---------

Co-authored-by: Shing Lyu <shinglyu@amazon.nl>

* feat: Telemetry metrics (#4414)

* Emit additional telemetry metrics

* Fix unit tests

* Emit endpoint failure to telemetry

* Address PR Comments

* Emit latency in telemetry

* Address PR Comments

* Addressed PR Comments

* Address PR Comments

* Fix tests

* Fix integ tests

---------

Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>

* documentation: change order of pipelines topics (#4427)

* prepare release v2.208.0

* update development version to v2.208.1.dev0

* feature: AutoGluon 1.0.0 image_uris update (#4426)

---------

Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: ci <ci>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>

* feat: add hub and hubcontent support in retrieval function for jumpstart model cache (#4438)

* feat: jsch jumpstart estimator support (#4439)

* Master jumpstart curated hub (#4464)

* add hub_arn support for accept_types, content_types, serializers, deserializers, and predictor (#4463)

* feature: JumpStart CuratedHub class creation and function definitions (#4448)

* MultiPartCopy with Sync Algorithm (#4475)

* first pass at sync function with util classes

* adding tests and update clases

* linting

* file generator class inheritance

* lint

* multipart copy and algorithm updates

* modularize sync

* reformatting folders

* testing for sync

* do not tolerate vulnerable

* remove prints

* handle multithreading progress bar

* update tests

* optimize function and add hub bucket prefix

* docstrings and linting

* rebase with master

* bad rebase

* trying to fix codecov

* uncomment codebuild-ci

---------

Co-authored-by: ci <ci>
Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
Co-authored-by: Anton Repushko <repuanto@amazon.com>
Co-authored-by: Sai Parthasarathy Miduthuri <54188298+saimidu@users.noreply.github.com>
Co-authored-by: Rohan Gujarathi <gujarathi.rohan@gmail.com>
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
Co-authored-by: cansun <80425164+can-sun@users.noreply.github.com>
Co-authored-by: Justin <justinm088@hotmail.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
@saimidu
feature: Add TensorFlow 2.14 image configs (aws#4446)
2dc1489
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
@saimidu @jiapinw
feature: Add TensorFlow 2.14 image configs (aws#4446)
cf041c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knikure knikure knikure approved these changes

@tejaschumbalkar tejaschumbalkar tejaschumbalkar approved these changes

@mufaddal-rohawala mufaddal-rohawala Awaiting requested review from mufaddal-rohawala mufaddal-rohawala is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees

@knikure knikure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saimidu @mufaddal-rohawala @tejaschumbalkar @knikure