Feat/gated model support #4510
Merged
Feat/gated model support #4510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add proprietary manifest/specs parsing add unittests for test_cache small refactoring address comments and more unittests fix linting and fix more tests fix: pylint feat: JumpStartModel class for prop models * remove unused imports and fix docstyle * fix: remove unused args * fix: remove unused args * fix: more unused vars * fix: slow tests * fix: unittests * added more tests to cover some lines * remove estimator warn check * chore: address comments re performance * fix: address comments * complete list experience and other fixes * fix: pylint * add doc utils and fix pylint * fix: docstyle * fix: doc * fix: default payloads * fix: doc and tags and enums * fix: jumpstart doc * rename to open_weights and fix filtering * update filter name * doc update * fix: black * rename to proprietary model and fix unittests * address comments * fix: docstyle and flake8 * address more comments and fix doc * put back doc utils for future refactoring * add prop model title in doc * doc update --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
…erializers, and predictor (aws#4463)
* first pass at sync function with util classes * adding tests and update clases * linting * file generator class inheritance * lint * multipart copy and algorithm updates * modularize sync * reformatting folders * testing for sync * do not tolerate vulnerable * remove prints * handle multithreading progress bar * update tests * optimize function and add hub bucket prefix * docstrings and linting
mabunday
reviewed
Mar 18, 2024
src/sagemaker/jumpstart/curated_hub/accessors/public_model_data.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-jumpstart-curated-hub #4510 +/- ##
===============================================================
Coverage ? 87.18%
===============================================================
Files ? 397
Lines ? 37256
Branches ? 0
===============================================================
Hits ? 32481
Misses ? 4775
Partials ? 0 ☔ View full report in Codecov by Sentry. |
akozd
approved these changes
Mar 18, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
evakravi
reviewed
Mar 18, 2024
| @@ -65,6 +66,10 @@ def generate_file_infos_from_model_specs( | |||
| files = [] | |||
| for dependency in HubContentDependencyType: | |||
| location: S3ObjectLocation = public_model_data_accessor.get_s3_reference(dependency) | |||
| # Training dependencies will return as None if training is unsupported | |||
| if not location or is_gated_bucket(location.bucket): | |||
There was a problem hiding this comment.
why are we checking for gated?
There was a problem hiding this comment.
We don't want to / can't copy any files over from the gated bucket
evakravi
reviewed
Mar 18, 2024
| model_version=self.model_specs.version, | ||
| script_scope=model_scope, | ||
| ) | ||
| except ValueError: |
There was a problem hiding this comment.
Yeah, we can log something here, though I don't think we'll ever reach this since we're only calling this function if training is supported
evakravi
approved these changes
Mar 18, 2024
benieric
approved these changes
Mar 18, 2024
benieric
merged commit a632795
into
aws:master-jumpstart-curated-hub
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds support for gated models and models with training unsupported
Testing done:
Added unit tests for all new functions / logic pathways. Manually tested with Llama2-13b and other training unsupported
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.