Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting numpy 1.21.2 to 1.19.2 and adding regression #124

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

NikhilRaverkar
Copy link
Contributor

@NikhilRaverkar NikhilRaverkar commented Jul 14, 2022

Issue #, if available:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mabunday
Copy link
Contributor

Hi Nikhil, for each of these PRs let's make sure

  1. Our forks are up to date with the tips of the remote branches. If they aren't, we can always rebase and push instead of opening a new issue, too
  2. That tox is executed locally before opening the PR quickly catch small errors before we run the CodeBuild, which is slow to execute. This allows us to iterate faster
  3. Our commits and PRs titles/bodies are descriptive https://cbea.ms/git-commit/. Here I would suggest something like "Revert numpy from 1.21.0 to PyArrow compatible 1.19.2; Add unit test for parquet conversion (#106)" as fixing issue #106 doesn't tell us what the nature of the change or issue actually is

@NikhilRaverkar NikhilRaverkar changed the title Issue 106 Reverting numpy 1.21.2 to 1.19.2 and adding regression Jul 14, 2022
@NikhilRaverkar
Copy link
Contributor Author

The Build has succeeded for this change (build# 86) Hence sending out for review

@NikhilRaverkar NikhilRaverkar marked this pull request as ready for review July 14, 2022 22:51
@NikhilRaverkar NikhilRaverkar merged commit 980f6d2 into master Jul 15, 2022
@mabunday mabunday deleted the issue_106 branch August 4, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants