Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SAM Schema to support FunctionResponseTypes for Lambda SQS event sources #3322

Closed
andy2mrqz opened this issue Aug 24, 2023 · 3 comments
Labels

Comments

@andy2mrqz
Copy link
Contributor

Summary

In October, 2022 there was an issue to update the SAM documentation to
recognize FunctionResponseTypes as a valid option for Lambda SQS event sources.

While that is now live in the documentation, the current schema.json file does not list it as a valid attribute. This results in the editor displaying an error when using this property in an SQS Event for Lambda.

Request:

Please update the schema so the editor can properly check SQS event properties.

Screenshots:

image
^ the error in the template.yaml file
image
^ the SQSEventProperties schema, missing FunctionResponseTypes

@andy2mrqz andy2mrqz added the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Aug 24, 2023
@GavinZZ
Copy link
Contributor

GavinZZ commented Aug 24, 2023

Hi @andy2mrqz, thanks for raising an issue. I'll investigate it. Meanwhile we also welcome and appreciate any contribution.

@GavinZZ GavinZZ added type/bug and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Aug 24, 2023
andy2mrqz added a commit to andy2mrqz/serverless-application-model that referenced this issue Aug 24, 2023
@andy2mrqz
Copy link
Contributor Author

Hi @andy2mrqz, thanks for raising an issue. I'll investigate it. Meanwhile we also welcome and appreciate any contribution.

Thanks @GavinZZ. I added a PR to address this - attempted to follow the development guidelines (mentioned in the PR).

Hope that helps!

GavinZZ pushed a commit that referenced this issue Aug 24, 2023
@GavinZZ
Copy link
Contributor

GavinZZ commented Aug 25, 2023

Thanks @andy2mrqz, the PR has been merged. Please give it 1~2 weeks for the changes to roll out. Closing this issue/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants