Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openapiversion bails if it is not a string #1104

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

praneetap
Copy link
Contributor

@praneetap praneetap commented Aug 28, 2019

Issue #, if available:

Description of changes:
I am seeing tons of errors where SAM is bailing when the template defines openapi without the quotes.
Description of how you validated changes:
Modified existing tests to remove the quotes from openapiversion value, and the output does not change.
Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Some minor cleanup comments. Should this go into a 1.14.1 patch release or is it ok to roll it into 1.15.0?

samtranslator/model/api/api_generator.py Outdated Show resolved Hide resolved
samtranslator/model/api/api_generator.py Outdated Show resolved Hide resolved
@praneetap
Copy link
Contributor Author

@jlhood addressed your comments, please take a look!

@codecov-io
Copy link

Codecov Report

Merging #1104 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1104      +/-   ##
===========================================
+ Coverage    94.75%   94.76%   +<.01%     
===========================================
  Files           71       71              
  Lines         3472     3474       +2     
  Branches       678      678              
===========================================
+ Hits          3290     3292       +2     
  Misses          93       93              
  Partials        89       89
Impacted Files Coverage Δ
samtranslator/translator/translator.py 99% <ø> (ø) ⬆️
samtranslator/model/api/api_generator.py 96.65% <100%> (-0.03%) ⬇️
samtranslator/swagger/swagger.py 95.94% <100%> (+0.01%) ⬆️
samtranslator/plugins/globals/globals.py 99.02% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a1096...043efcc. Read the comment docs.

@jlhood jlhood requested a review from keetonian August 30, 2019 20:09
@jlhood jlhood assigned keetonian and unassigned jlhood Aug 30, 2019
@keetonian keetonian merged commit fd718bb into aws:develop Sep 4, 2019
ShreyaGangishetty pushed a commit to ShreyaGangishetty/serverless-application-model that referenced this pull request Sep 4, 2019
@praneetap praneetap mentioned this pull request Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants