-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: openapiversion bails if it is not a string #1104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. Some minor cleanup comments. Should this go into a 1.14.1 patch release or is it ok to roll it into 1.15.0?
@jlhood addressed your comments, please take a look! |
Codecov Report
@@ Coverage Diff @@
## develop #1104 +/- ##
===========================================
+ Coverage 94.75% 94.76% +<.01%
===========================================
Files 71 71
Lines 3472 3474 +2
Branches 678 678
===========================================
+ Hits 3290 3292 +2
Misses 93 93
Partials 89 89
Continue to review full report at Codecov.
|
Issue #, if available:
Description of changes:
I am seeing tons of errors where SAM is bailing when the template defines openapi without the quotes.
Description of how you validated changes:
Modified existing tests to remove the quotes from openapiversion value, and the output does not change.
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.