Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove ENI manual deletion #3613

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented Jun 12, 2024

Issue #, if available

None

Description of changes

Removes the code that deletes ENI. This was added because MQ was not deleting the ENIs which is not happening.

Description of how you validated changes

make pr

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfuss jfuss requested a review from a team as a code owner June 12, 2024 19:30
@aaythapa
Copy link
Contributor

I see from the old commit this was originally added because

Number of unused Network Interfaces can accumulate and fail future test runs when there’s no more available IP addresses in the pre-created subnets.

will we see the same errors after removing it?

@jfuss
Copy link
Contributor Author

jfuss commented Jun 12, 2024

@aaythapa

will we see the same errors after removing it?

We shouldn't. MQ reached out because they are attempting to delete ENIs that no longer exist, and the running assumption is it is caused by this.

@aaythapa aaythapa merged commit f355068 into aws:develop Jun 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants