Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude breaking pydantic version #3620

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

aaythapa
Copy link
Contributor

@aaythapa aaythapa commented Jun 24, 2024

Issue #, if available

#3617

Description of changes

Pydantic versions 1.10.15 and 1.10.17 introduced breaking changes. Exclude those versions from being installed.

Description of how you validated changes

Ran make init with pydantic>=1.8,!=1.10.15,!=1.10.17,<2 (to insure pydantic V1 got installed). pydantic 1.10.16 was installed

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aaythapa aaythapa requested a review from a team as a code owner June 24, 2024 23:51
@xazhao
Copy link
Contributor

xazhao commented Jun 24, 2024

Should we pin the version as 1.10.16 or < 1.10.15? If they release a new version without fixing it, we will have to change it again.

@aaythapa
Copy link
Contributor Author

aaythapa commented Jun 25, 2024

Should we pin the version as 1.10.16 or < 1.10.15? If they release a new version without fixing it, we will have to change it again.

If we pin a version now then we'd have to unpin eventually no? This way if the next version fixes it then we don't have to make another change. Imo if they release another version without fixing this issue then we can pin a version 😅

@xazhao
Copy link
Contributor

xazhao commented Jun 25, 2024

Yeah if we pin a version now we will need to unpin eventually. There will be a little additional work but it's safer to make sure we don't use the bad version in the future (we can test the version before unpinning). Not a merge blocker though.

@aaythapa aaythapa merged commit 84ab6ee into aws:develop Jun 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants