Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add retry for statemachine integ test #3630

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

godwingrs22
Copy link
Member

Issue #, if available

N/A

Description of changes

test_state_machine_with_api_single_quotes_input integ test is failing sometimes with status code 403 from APIGW. This test seems flaky test. However, We are adding retry mechanism to this test which can make this test pass.

Error:

Request to .... failed with status: 403, expected status: 200

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@godwingrs22 godwingrs22 requested a review from a team as a code owner July 31, 2024 01:50
@GavinZZ
Copy link
Contributor

GavinZZ commented Aug 1, 2024

IIRC, we already have retry logics set up when running integ tests. Let me confirm it.

@GavinZZ
Copy link
Contributor

GavinZZ commented Aug 1, 2024

IIRC, we already have retry logics set up when running integ tests. Let me confirm it.

That’s only when running integ test locally. For pipeline deployment, there’s no retry setup. This changes LGTM.

@godwingrs22
Copy link
Member Author

godwingrs22 commented Aug 1, 2024

IIRC, we already have retry logics set up when running integ tests. Let me confirm it.

That’s only when running integ test locally. For pipeline deployment, there’s no retry setup. This changes LGTM.

Thanks @GavinZZ for the review.

@godwingrs22 godwingrs22 merged commit 16da6e7 into develop Aug 1, 2024
7 checks passed
@godwingrs22 godwingrs22 deleted the fix/integtest branch August 1, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants