Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(example): improve microservice-http-endpoint-python3 example #415

Merged
merged 7 commits into from
May 25, 2018
Merged

docs(example): improve microservice-http-endpoint-python3 example #415

merged 7 commits into from
May 25, 2018

Conversation

bedge
Copy link
Contributor

@bedge bedge commented May 2, 2018

  1. Remove superfluous index.js file (looks to be accidentally duplicated from another example)
  2. Include the dynamo DB in the template so one does not need to manually create it, and, sppecify it as the 1st parameter of every API call.
  3. Fix the "no params" GET case that was failing trying to interpret None as a list.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Bruce Edge added 6 commits May 2, 2018 14:19
@bedge bedge changed the title Cleanup and docs. Cleanup and docs, make easier to run and test. May 5, 2018
@brettstack brettstack self-assigned this May 22, 2018
Copy link
Contributor

@brettstack brettstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks (and sorry for the delay). Just a couple minor comments.

CodeUri: .
Description: >-
A simple backend (read/write to DynamoDB) with a RESTful API endpoint
using Amazon API Gateway.
MemorySize: 512
#MemorySize: 512
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

# Args: $1: API GW path
# $2 json payload data file
#
# eg: ./test.sh https://vxldx8ck9i.execute-api.us-west-2.amazonaws.com/Prod/MyResource ./test-payload.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace your API ID with YOUR_API_ID and region with YOUR_REGION

Copy link
Contributor

@brettstack brettstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brettstack brettstack changed the title Cleanup and docs, make easier to run and test. docs(example): improve microservice-http-endpoint-python3 example May 22, 2018
Copy link
Contributor

@dhruvsood dhruvsood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Bruce!!

@brettstack brettstack merged commit e1fcea6 into aws:develop May 25, 2018
brettstack added a commit that referenced this pull request Jun 11, 2018
* doc: update DESIGN.md to include an Overview and entry point for SAM (#370)

* Update DESIGN.md to include an Overview and entry point for SAM

* Updated wording in DESIGN.md based on PR feedback

* docs(example): improve microservice-http-endpoint-python3 example (#415)

* Remove unnecessary index.js"

* Moved common config to template Globals and uncomment debug log.

* Add sample payload and commands for testing.

* Rename test script as a script.

* Exit from script after command.

* Simplify use case for easier startup.

- Move table creation into template.
- Eliminates need to provide table name in every REST call.
- Fix GET with no params.
- Split test.sh script from output log.

* Address requested changes.

* doc(example): update api_backend example to use ES6 arrow function immediate return (#446)

Since this code is using ES6 we can use the short version of returning a param

* feat(event-source): add SQS as Lambda event source (#451)

* feat(cli): add lightweight transformer cli (#459)

* bug: fix ANY method ARN generation using wildcard (#449)

* fix(event-source): fix SQS Queue schema to allow intrinsic functions (#465)

* fix: log a warning on invalid schema validation (#466)
brettstack added a commit that referenced this pull request Jun 12, 2018
* doc: update DESIGN.md to include an Overview and entry point for SAM (#370)

* Update DESIGN.md to include an Overview and entry point for SAM

* Updated wording in DESIGN.md based on PR feedback

* docs(example): improve microservice-http-endpoint-python3 example (#415)

* Remove unnecessary index.js"

* Moved common config to template Globals and uncomment debug log.

* Add sample payload and commands for testing.

* Rename test script as a script.

* Exit from script after command.

* Simplify use case for easier startup.

- Move table creation into template.
- Eliminates need to provide table name in every REST call.
- Fix GET with no params.
- Split test.sh script from output log.

* Address requested changes.

* doc(example): update api_backend example to use ES6 arrow function immediate return (#446)

Since this code is using ES6 we can use the short version of returning a param

* feat(event-source): add SQS as Lambda event source (#451)

* feat(cli): add lightweight transformer cli (#459)

* bug: fix ANY method ARN generation using wildcard (#449)

* fix(event-source): fix SQS Queue schema to allow intrinsic functions (#465)

* fix: log a warning on invalid schema validation (#466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants