Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-511 Support Accept-Language header values containing country subtag #512

Merged
merged 2 commits into from
Apr 14, 2023
Merged

gh-511 Support Accept-Language header values containing country subtag #512

merged 2 commits into from
Apr 14, 2023

Conversation

kerkhofsd
Copy link
Contributor

Issue #, if available: #511

Description of changes:

Support Accept-Language header values which also contain a country part.

Unlike mentioned in the GH issue, I did not use Locale#forLanguageTag to parse the language tag because it looks like invalid / unknown language tags result in an "empty" Locale object which I think might cause undesired side effects.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@kerkhofsd kerkhofsd changed the title gh-511 gh-511 Support Accept-Language header values containing country subtag Apr 14, 2023
@deki
Copy link
Collaborator

deki commented Apr 14, 2023

Thank you very much for your contribution @kerkhofsd.

@deki deki merged commit c9c573f into aws:main Apr 14, 2023
@kerkhofsd kerkhofsd deleted the gh-511 branch April 14, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants