Deprecate asyncInit & account for other initialization types #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richarddd
changed the title
richarddd
changed the title
deki
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Thank you very much for your contribution @richarddd. We can include this for 2.0.0 so please change the comments accordingly.
Btw. as we are now making it the default, would you be interested to look into #276 as well?
| @@ -165,7 +165,7 @@ public Builder responseTypeClass(Class<ResponseType> responseType) { | |||
| /** | |||
| * Uses an async initializer with the given start time to calculate the 10 seconds timeout. | |||
| * | |||
| * @deprecated As of release 1.5 this method is deprecated in favor of the parameters-less one {@link ServletLambdaContainerHandlerBuilder#asyncInit()}. | |||
| * @deprecated As of release 2.1 this method is deprecated. Initializer is always async if running in on-demand. | |||
There was a problem hiding this comment.
should be 2.0.0 (currently we just have 2.0.0-M1 and 2.0.0-M2 milestone releases out there)
| @@ -178,6 +178,7 @@ public Builder asyncInit(long actualStartTime) { | |||
| /** | |||
| * Uses a new {@link AsyncInitializationWrapper} with the no-parameter constructor that takes the actual JVM | |||
| * start time | |||
| * @deprecated As of release 2.1 this method is deprecated. Initializer is always async if running in on-demand. | |||
There was a problem hiding this comment.
should be 2.0.0 (currently we just have 2.0.0-M1 and 2.0.0-M2 milestone releases out there)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes: #507
Description of changes:
asyncInit()setting is now deprecated and always enabled unless users opt out by providing their owninitializationWrapper. It's more sensible to provide a working default (that users can opt out of) than have a broken default depending on available resources and init times.AsyncInitializationWrapper also falls back to InitializationWrapper if initialization mode is not "on-demand" to account for other execution modes (SnapStart and PC)
By submitting this pull request