GH-805 Fix web context initialization during snapstart #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated to s-c-function-serverless-webb 4.1.1-SNAPSHOT This commit forces wait for full context initialization if context is created during snapstart creation
deki
reviewed
Mar 26, 2024
| @@ -53,6 +53,10 @@ public SpringDelegatingLambdaContainerHandler() { | |||
| public SpringDelegatingLambdaContainerHandler(Class<?>... startupClasses) { | |||
| this.startupClasses = startupClasses; | |||
| this.mvc = ServerlessMVC.INSTANCE(this.startupClasses); | |||
| if (System.getenv().containsKey("AWS_LAMBDA_INITIALIZATION_TYPE") | |||
| && System.getenv().get("AWS_LAMBDA_INITIALIZATION_TYPE").equals("snap-start")) { | |||
There was a problem hiding this comment.
shouldn't that be !"on-demand" to cover "provisioned-concurrency" as well?
There was a problem hiding this comment.
Perhaps, although I am not quite sure what 'on-demand' is
There was a problem hiding this comment.
Also, you can change s-c-function version from snapshot to 4.1.1 as we just had a release
There was a problem hiding this comment.
AWS_LAMBDA_INITIALIZATION_TYPE – The initialization type of the function, which is on-demand, provisioned-concurrency, or snap-start.
For provisioned-concurrency it would also make sense to initialize the context earlier - therefore !("on-demand") would cover this as well.
There was a problem hiding this comment.
ahha, got it. will add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#805
Also updated to s-c-function-serverless-webb 4.1.1-SNAPSHOT This commit forces wait for full context initialization if context is created during snapstart creation
By submitting this pull request