RestXml Deserialization support #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
changed the title
JordonPhillips
requested changes
Aug 17, 2020
.../src/main/java/software/amazon/smithy/go/codegen/integration/HttpProtocolGeneratorUtils.java
Outdated
Show resolved
Hide resolved
jasdel
reviewed
Aug 19, 2020
.../src/main/java/software/amazon/smithy/go/codegen/integration/HttpProtocolGeneratorUtils.java
Outdated
Show resolved
Hide resolved
JordonPhillips
approved these changes
Aug 19, 2020
jasdel
suggested changes
Aug 19, 2020
...en/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/SmithyGoDependency.java
Outdated
Show resolved
Hide resolved
jasdel
reviewed
Aug 20, 2020
… error handling for different protocols
jasdel
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associates with smithy-lang/smithy#526 that fixes a protocol test.
Pairs with aws/aws-sdk-go-v2#667 for aws-sdk-go-v2 rest-xml deserialization support
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.