moves host prefix addition to a build step middleware #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
reviewed
Nov 3, 2020
...rc/main/java/software/amazon/smithy/go/codegen/integration/EndpointHostPrefixMiddleware.java
Show resolved
Hide resolved
skotambkar
force-pushed
the
signedForHostPrefix
branch
from
adba670
to
5cda8cc
Compare
skotambkar
force-pushed
the
signedForHostPrefix
branch
2 times, most recently
from
907a492
to
b6f4dc9
Compare
jasdel
approved these changes
Nov 6, 2020
skotambkar
force-pushed
the
signedForHostPrefix
branch
from
b6f4dc9
to
62c2a93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Endpoint host prefix addition was being performed after a request was signed. This led to a incorrectly signed request.
Description of changes:
[x] This changes moves the endpoint mutation to a build step middleware, that will be performed before signing.
[x] We also add a
DisableEndpointHostPrefixandIsEndpointHostPrefixDisabledmethod on transport/http which provides an ability to turn host prefixing off. This would be useful when applying customizations or for testing purposes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Related to aws/aws-sdk-go-v2#862 and aws/aws-sdk-go-v2#863