Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify waiting logic in Rust DynamoDB examples #3593

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

jdisanti
Copy link
Contributor

@jdisanti jdisanti commented Sep 9, 2022

I'm making some breaking changes to retry in the AWS SDK for Rust in smithy-lang/smithy-rs#1717 that cause the DynamoDB examples to fail to compile. These examples were using a complicated retry policy override mechanism to wait for table creation. Rather than preserve that, I rewrote the waiting logic to be a simple to follow function. In the future when the SDK supports waiters, this can be simplified further.

  • Test the changed code
  • Run a linter against the changed code and implement the resulting suggestions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@beqqrry-aws beqqrry-aws self-assigned this Sep 12, 2022
@beqqrry-aws beqqrry-aws self-requested a review September 12, 2022 16:13
@scmacdon scmacdon merged commit 248b6ff into awsdocs:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants