Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): add webassembly example #4325

Merged
merged 18 commits into from
Mar 6, 2023

Conversation

eduardomourar
Copy link
Contributor

@eduardomourar eduardomourar commented Jan 30, 2023

aws-doc-sdk-examples Pull Request

I'm submitting a new SDK code example

The example depends on this PR.

Confirm you have met the following minimum requirements:

  • Add the following copyright notice to the top of each file. See the LICENSE agreement for the terms of the copyright.

Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: Apache-2.0

  • Create unit tests for all paths through the code, and confirm that the all the tests pass. For recommendations, see How we test code examples.
  • Run a linter against all code and implement the resulting suggestions. For recommendations, see Linters run on check in.
  • Add minimum usage documentation as comments in the code. For recommendations, see Code comment guidelines.

Open source license adherence

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@DavidSouther
Copy link
Contributor

Hey, @eduardomourar, just wanted to let you know I am working on a review for this PR, but I need to do a bit of research on the WebAssembly side of things first! Thank you for your contributions!

Copy link
Contributor

@DavidSouther DavidSouther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for this! It's a feature that's been in my backlog for an April timeframe, but this definitely jumpstarts that :) Most of the review comments are small nits in the HTML/JS side; the Rust looks really solid. As I mention in a specific comment, this needs a larger User Guide entry, but this is a great start.

rust_dev_preview/webassembly/www/index.html Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/www/index.html Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/www/index.html Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/www/index.html Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/www/index.js Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/www/env.js Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/additional-ci Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/www/env.js Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/src/lib.rs Show resolved Hide resolved
rust_dev_preview/webassembly/src/lib.rs Show resolved Hide resolved
@DavidSouther DavidSouther self-assigned this Feb 13, 2023
@eduardomourar eduardomourar marked this pull request as ready for review February 15, 2023 22:47
Fix closing head tag
@DavidSouther
Copy link
Contributor

I'm adding @lkdavies, our team's editor, for review of the README and prose.

DavidSouther
DavidSouther previously approved these changes Feb 16, 2023
Copy link
Contributor

@lkdavies lkdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

rust_dev_preview/webassembly/README.md Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/README.md Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/README.md Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/www/static/index.html Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/www/static/index.html Outdated Show resolved Hide resolved
rust_dev_preview/webassembly/www/static/index.html Outdated Show resolved Hide resolved
@DavidSouther DavidSouther self-requested a review February 22, 2023 18:17
DavidSouther
DavidSouther previously approved these changes Feb 22, 2023
DavidSouther
DavidSouther previously approved these changes Mar 2, 2023
fmt lint
@irenepsmith irenepsmith merged commit a0fb259 into awsdocs:main Mar 6, 2023
@eduardomourar eduardomourar deleted the rust-webassembly-example branch March 6, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants