write default kubeletConfig to config path in drop-in dir versions #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermckinnon
requested changes
Jan 30, 2024
ndbaker1
force-pushed
the
drop-in-config
branch
from
a45686f
to
9d39dd9
Compare
ndbaker1
force-pushed
the
drop-in-config
branch
from
9d39dd9
to
8d18155
Compare
|
@cartermckinnon the description's been updated to match the behavior unless we are pending anything else |
cartermckinnon
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
loggingconfiguration to a custom type.configpath rather than theconfig-dir. This gives the correctKubeletConfigurationdefaults when parsing rather than using the raw json.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
launch AL2023 1.29 ami and verify nodes don't enounter
panic: non-positive interval for NewTickererrorSee this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.