Add iam instance profile support #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSchultz-clumio
force-pushed
the
feature/iam-instance-profile
branch
from
1f70439
to
a6058e9
Compare
In order to better use SSM for building rather than SSH, we need to be able to configure the iam_instance_profile. This change adds `iam_instance_profile` that can be used when setting `ssh_interfance` to `session_manager`. When using `session_manager` you will need to use a non-minimal version of the source ami to ensure it has the SSM agent available at launch. You may also need to increase the volume size from 4 depending on which source AMI you use.
AlexSchultz-clumio
force-pushed
the
feature/iam-instance-profile
branch
from
a6058e9
to
d99cc72
Compare
|
@cartermckinnon please review when you have a moment |
|
/ci build |
|
@cartermckinnon roger that! I've dispatched a workflow. 👍 |
|
@cartermckinnon the workflow that you requested has completed. 🎉
|
cartermckinnon
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
In order to use SSM for building rather than SSH, we need to be able to configure the
iam_instance_profile. This change addsiam_instance_profilethat can be used when settingssh_interfancetosession_manager.When using
session_manageryou will need to use a non-minimal version of the source ami to ensure it has the SSM agentavailable at launch. You may also need to increase the volume size from 4 depending on which source AMI you use.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
Successful build with
make k8s=1.29 ssh_interface=session_manager iam_instance_profile=ssm-profile aws_region=us-east-2 source_ami_filter_name="amzn2-ami-hvm-*" launch_block_device_mappings_volume_size=8