-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InstanceOptions with LocalDiskStrategy #1688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some kind of issue going on with the |
Fixed it by adding |
cartermckinnon
force-pushed
the
local-disk-strategy
branch
from
February 24, 2024 00:23
30a4f99
to
579fd51
Compare
ndbaker1
reviewed
Feb 24, 2024
ndbaker1
reviewed
Feb 24, 2024
ndbaker1
reviewed
Feb 25, 2024
ndbaker1
approved these changes
Feb 26, 2024
ndbaker1
reviewed
Feb 26, 2024
ndbaker1
reviewed
Feb 26, 2024
Issacwww
approved these changes
Feb 26, 2024
6 tasks
atmosx
pushed a commit
to gathertown/amazon-eks-ami
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We've removed the default raid0 setup in #1686, so this adds the ability to setup local disks in
NodeConfig
.Example:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.