[WIP] Validate external types with CRD machinery #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermckinnon
force-pushed
the
validation-with-crd-spec
branch
from
01236bd
to
9b77dcb
Compare
Issacwww
approved these changes
Feb 27, 2024
ndbaker1
reviewed
Feb 27, 2024
| @@ -28,6 +28,9 @@ func DecodeNodeConfig(data []byte) (*internalapi.NodeConfig, error) { | |||
| if gvk.Group != api.GroupName { | |||
| return nil, fmt.Errorf("failed to decode %q, unexpected group: %s", gvk.Kind, gvk.Group) | |||
| } | |||
| if err := ValidateExternalType(obj, *gvk); err != nil { | |||
There was a problem hiding this comment.
based on tests, this is breaking how we merge partial configs 😞
will we have to do the merging in json/yaml like kubelet? https://github.com/kubernetes/kubernetes/blob/master/cmd/kubelet/app/server.go#L314-L345
|
/ci |
|
@cartermckinnon this PR is not currently mergeable, you'll need to rebase it first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds validation for the external API types using the same mechanism that the API server uses for CRD's. Validation directives like
requiredare only expressed in the CRD spec, so we need to leverage the core validation in the API server to leverage it.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.