Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(al2023): Do not bind containerd restarts to kubelet #1854

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

cartermckinnon
Copy link
Member

@cartermckinnon cartermckinnon commented Jun 18, 2024

Issue #, if available:

Fixes #1846.

Description of changes:

This updates the kubelet.service on AL2023 to be loosely-coupled with containerd, so that restarts/kills of containerd do not impact kubelet.

We're not making this change on AL2 because folks may see different behavior if they're starting/stopping either of these units in their existing user data.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cartermckinnon
Copy link
Member Author

/ci

Copy link
Contributor

@cartermckinnon roger that! I've dispatched a workflow. 👍

Copy link
Contributor

@cartermckinnon the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.21 / al2success ✅success ✅
1.22 / al2success ✅success ✅
1.23 / al2success ✅success ✅
1.23 / al2023success ✅success ✅
1.24 / al2success ✅success ✅
1.24 / al2023success ✅success ✅
1.25 / al2success ✅success ✅
1.25 / al2023success ✅success ✅
1.26 / al2success ✅success ✅
1.26 / al2023success ✅success ✅
1.27 / al2success ✅success ✅
1.27 / al2023success ✅success ✅
1.28 / al2success ✅failure ❌
1.28 / al2023success ✅success ✅
1.29 / al2success ✅success ✅
1.29 / al2023success ✅success ✅
1.30 / al2success ✅success ✅
1.30 / al2023success ✅success ✅

@cartermckinnon
Copy link
Member Author

The 1.28 / al2 failure was a network flake, not related.

@ndbaker1 ndbaker1 merged commit 24e36a7 into main Jun 19, 2024
10 checks passed
@ndbaker1 ndbaker1 deleted the no-kubelet-restart branch June 19, 2024 16:48
mebays pushed a commit to mebays/amazon-eks-ami that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EKS AMI shouldn't restart Kubelet when containerd is restarted
3 participants