Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ulimits for docker containers. #186

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

micahhausler
Copy link
Member

Issue #, if available:

Rebase of #132 for docker 18.06. The configuration failed for docker 17.06, but works on 18.06

Description of changes:

Increase the default ulimits for containers

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@micahhausler micahhausler merged commit 5a57ab8 into awslabs:master Feb 15, 2019
@micahhausler micahhausler deleted the ulimits branch February 15, 2019 18:09
@victortrac
Copy link

This change seemed to have broken elasticsearch on EKS:

ERROR: [1] bootstrap checks failed
[1]: max file descriptors [8192] for elasticsearch process is too low, increase to at least [65536]

ES pods on the new AMI released today are failing with that error. Pods on nodes created a few weeks ago are working as expected.

@nitin302
Copy link

Is there any way some other default was being effected before? I am using amazon-eks-node-1.10-v20181210 and containers already have 65536 as the ulimit setting. The host level setting is 1024 though!

@geerlingguy
Copy link

Another 'me too'—the latest AMI broke our Elasticsearch pods and we had to manually revert the change.

@athilaelhuno
Copy link

Which version has this merge, because the amazon-eks-node-1.11-v20190220 (ami-0eeeef929db40543c) has the unlimit set.

@cpanato
Copy link

cpanato commented Mar 2, 2019

same issue for me :/

When the new AMI will be released?

@agnewp
Copy link

agnewp commented Mar 28, 2019

just updated to the latest version of AMI, broke all my elastic search nodes with the file descriptor error. This kind of thing should be adjustable!

@whereisaaron
Copy link

@agnewp @cpanato I think watch this issue, we're expecting 1.11.8 images for EKS any day, which hopefully will include this fix.

aws/containers-roadmap#188

@MMartyn
Copy link

MMartyn commented Mar 28, 2019

New AMI broke my elasticsearch as well. I opened it up to see what was going on and it appears that /etc/sysconfig/docker still had the OPTION that has the ulimit. It is almost like this isn’t having the intended affect https://github.com/awslabs/amazon-eks-ami/blob/master/install-worker.sh#L66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants