Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max-pods-calculator to consider only network card 0 #1930

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

Pavani-Panakanti
Copy link
Contributor

Issue #, if available: Customer issue

Description of changes:
CNI only works with network card 0 for pods creation. In max-pods-calculator we are taking interfaces from all network cards which is resulting in wrong values for instances with multiple network cards. This is causing issues to cx who are using this script to generate max pod values.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

Ran the script across all instance types here https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/master/misc/eni-max-pods.txt and verified max pods values from the above file

@Pavani-Panakanti Pavani-Panakanti marked this pull request as ready for review August 21, 2024 21:56
Copy link

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orsenthil
Copy link

@cartermckinnon - please review and merge this.

Copy link
Member

@cartermckinnon cartermckinnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @Pavani-Panakanti 🙏🏻

@cartermckinnon cartermckinnon merged commit 6e58760 into awslabs:main Aug 22, 2024
10 checks passed
@miguellongo
Copy link

Hello guys.

I'm looking into new AMIs where errors about pod density happens.

When I use this AMI (ami-060a6e3365dc94a3c), I saw this pull request into max-pods-calculator and I dont got more problems with CNI. Using the latest AMI, I can't see this pull request and I have problems with density and CNI again.

Is this problem on max-pods-calculator scripts or other config into EKS?

image

image

image

Thanks guys.

@mattcjo
Copy link

mattcjo commented Sep 20, 2024

Hey @miguellongo ,

I talked with the Karpenter team on this issue, and it sounds like it's a bug on their end. The Karpenter team is targeting next week with a patch that should fix the problem. I will let you know when it's been completed so you can verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants