Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates(al23): pass build image for nodeadm #1971

Merged
merged 1 commit into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/usage/al2023.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<!-- template-variable-table-boundary -->
| Variable | Description |
| - | - |
| `enable_accelerator` | Vendor that provides the GPU or accelerator hardware. Currently we support Neuron and NVIDIA. |
| `ami_component_description` | |
| `ami_description` | |
| `ami_name` | |
Expand All @@ -21,15 +20,17 @@
| `binary_bucket_region` | |
| `containerd_version` | |
| `creator` | |
| `enable_accelerator` | Vendor that provides the GPU or accelerator hardware. Currently we support Neuron and NVIDIA. |
| `enable_efa` | Valid options are ```true``` or ```false```. Wheather or not to install the software needed to use AWS Elastic Fabric Adapter (EFA) network interfaces. |
| `enable_fips` | Install openssl and enable fips related kernel parameters |
| `encrypted` | |
| `iam_instance_profile` | The name of an IAM instance profile to launch the EC2 instance with. |
| `enable_efa` | Valid options are ```true``` or ```false```. Wheather or not to install the software needed to use AWS Elastic Fabric Adapter (EFA) network interfaces. |
| `instance_type` | |
| `kms_key_id` | |
| `kubernetes_build_date` | |
| `kubernetes_version` | |
| `launch_block_device_mappings_volume_size` | |
| `nodeadm_build_image` | Image to use as a build environment for nodeadm |
| `nvidia_driver_major_version` | To be used only when ```enable_accelerator = nvidia```. Driver version to install, depends on what is available in NVIDIA repository. |
| `remote_folder` | Directory path for shell provisioner scripts on the builder instance |
| `runc_version` | |
Expand Down
2 changes: 0 additions & 2 deletions templates/al2023/provisioners/install-nodeadm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ set -o pipefail
set -o nounset
set -o errexit

BUILD_IMAGE=public.ecr.aws/eks-distro-build-tooling/golang:1.22

sudo systemctl start containerd

sudo nerdctl run \
Expand Down
6 changes: 4 additions & 2 deletions templates/al2023/template.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"_comment": "All template variables are enumerated here; and most variables have a default value defined in a variables.json for each kubernetes minor version",
"variables": {
"enable_accelerator": null,
"ami_component_description": null,
"ami_description": null,
"ami_name": null,
Expand All @@ -17,15 +16,17 @@
"binary_bucket_region": null,
"containerd_version": null,
"creator": null,
"enable_accelerator": null,
"enable_efa": null,
"enable_fips": null,
"encrypted": null,
"iam_instance_profile": null,
"enable_efa": null,
"instance_type": null,
"kms_key_id": null,
"kubernetes_build_date": null,
"kubernetes_version": null,
"launch_block_device_mappings_volume_size": null,
"nodeadm_build_image": null,
"nvidia_driver_major_version": null,
"remote_folder": null,
"runc_version": null,
Expand Down Expand Up @@ -211,6 +212,7 @@
"remote_folder": "{{ user `remote_folder`}}",
"script": "{{template_dir}}/provisioners/install-nodeadm.sh",
"environment_vars": [
"BUILD_IMAGE={{user `nodeadm_build_image`}}",
"PROJECT_DIR={{user `working_dir`}}/nodeadm"
]
},
Expand Down
7 changes: 4 additions & 3 deletions templates/al2023/variables-default.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"enable_accelerator": "",
"ami_component_description": "(k8s: {{ user `kubernetes_version` }}, containerd: {{ user `containerd_version` }})",
"ami_description": "EKS-optimized Kubernetes node based on Amazon Linux 2023",
"ami_regions": "",
Expand All @@ -13,12 +12,14 @@
"binary_bucket_region": "us-west-2",
"containerd_version": "1.7.11-*",
"creator": "{{env `USER`}}",
"enable_accelerator": "",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorted fields.

"enable_efa": "false",
"enable_fips": "false",
"encrypted": "false",
"kms_key_id": "",
"iam_instance_profile": "",
"enable_efa": "false",
"kms_key_id": "",
"launch_block_device_mappings_volume_size": "20",
"nodeadm_build_image": "public.ecr.aws/eks-distro-build-tooling/golang:1.23",
"nvidia_driver_major_version": "555",
"remote_folder": "/tmp",
"runc_version": "*",
Expand Down
Loading