eks:descibe-cluster for Non-Private VPC #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Avoiding eks:descibe-cluster call for Private VPC
Description of changes:
As a part of SCIDR Feature launch, we were making a describe cluster call for all the customers if one of the Cluster dns ip, CA data or endpoint url was missing. This was affecting the customers in Private VPC.
Now, we are making a describe cluster call to get DNS IP only for users who do not pass either CA data, endpoint url or both. For customers, who pass both CA data and endpoint, DNS IP will be determined from VPC IP This will impact the customers who choose the SCIDR feature but pass both CA data and endpoint as their SCIDR value will be different from DNS IP (determined from VPC IP)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.