Make Record Subscriptable #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `record` that was passed was subscriptable as it was a simple dictionary. This mechanism means that I am still able to do `record['data']` thereby maintaining backwards compatibility.
|
Please confirm that we can use, modify, copy, and redistribute this contribution. Thanks. |
|
I confirm that all changes contained in this pull request can be used, modified, copied, and redistributed. |
|
Thanks for this, working on merging it soon. |
pfifer
added a commit
to pfifer/amazon-kinesis-client-python
that referenced
this pull request
Jan 3, 2017
PR awslabs#39: Make record objects subscriptable for backwards compatibility.
pfifer
added a commit
that referenced
this pull request
Jan 3, 2017
PR #39: Make record objects subscriptable for backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
recordthat was passed was subscriptable as it was a simple dictionary. This mechanism means that I am still able to dorecord['data']thereby maintaining backwards compatibility.