KinesisProducer is not correctly destroying callbackCompletionExecuto… #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…awslabs#224 When destroying KinesisProducer instances, destroy method is not shutting down callbackCompletionExecutor. This makes Daemon child object to still be alive occupying 8MB of heap memory each one. Creating and destroying lots of KinesisProducer instances will result in a Heap Out Of Memory exception.
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r #224
When destroying KinesisProducer instances, destroy method is not shutting down callbackCompletionExecutor. This makes Daemon child object to still be alive occupying 8MB of heap memory each one.
Creating and destroying lots of KinesisProducer instances will result in a Heap Out Of Memory exception.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.