Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass proxy configuration in the Java wrapper to c++ library #351

Merged
merged 1 commit into from
May 26, 2021

Conversation

xinguaws
Copy link

@xinguaws xinguaws commented Apr 6, 2021

Issue numbers: #13 #186

Description of changes: Pass proxy configuration from java wrapper to C++ AWS SDK.

This change has been built and tested in a customer environment, no issues are found.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@xinguaws xinguaws force-pushed the feature/proxy_support_0.14.6 branch from e83a27b to 9d7f8ea Compare April 14, 2021 22:54
@xinguaws xinguaws force-pushed the feature/proxy_support_0.14.6 branch from 9d7f8ea to b62dbaa Compare April 15, 2021 14:34
Copy link
Contributor

@yatins47 yatins47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngsharsha
Copy link

any update on this PR ?

@joshua-kim
Copy link
Contributor

Fixed the build in #356, re-running travis before merging.

@joshua-kim joshua-kim closed this May 26, 2021
@joshua-kim joshua-kim reopened this May 26, 2021
@joshua-kim
Copy link
Contributor

Reopened to re-enqueue a build...

@joshua-kim joshua-kim merged commit 7d8c70d into awslabs:master May 26, 2021
@joshua-kim
Copy link
Contributor

The Xenial build is passing, looks like Travis is having other issues unrelated to this and can't clone the repo for some reason. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants