Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the upgrade of jakarta.xml.bind to be backward-compatible with Java8 #465

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

zengyu714
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Revert the upgrade of jakarta.xml.bind to be backward-compatible with Java8
  • Add more logs to verify that IMDSV2 is used correctly for getting region info for KPL running in EC2 instances

Test

  • Confirmed that both Java11 and Java8 can build successfully with recently introduced dependencies for javax
  • IMDS validation
# Region is set in configuration
[kpl-daemon-0003] INFO com.amazonaws.services.kinesis.producer.LogInputStreamReader - [2023-01-03 16:44:13.525020] [0x00008a94][0x000000011715b600] [info] [main.cc:257] Region has been successfully set to us-east-1 from user's input configuration
# Region is NOT set in configuration
[kpl-daemon-0003] INFO com.amazonaws.services.kinesis.producer.LogInputStreamReader - [2023-01-04 00:56:42.318065] [0x00003389][0x0000ffff9076f010] [info] [main.cc:269] Region has been successfully set to us-west-2 using EC2 metadata (IMDSV2)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zengyu714 zengyu714 merged commit 064f1d9 into awslabs:master Jan 4, 2023
@zengyu714 zengyu714 deleted the imdsv2 branch January 4, 2023 17:54
@piotrwielgolaski-tomtom

@zengyu714 it seems that AWS SDK version used in PR does not have critical change - aws/aws-sdk-cpp@6d56e2c#diff-b2721b33711ef56d764c97da39d9fdaf610bcd9fefcbe8855ed197cc6f58cd50R314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants