Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Producer C SDK to a Release Tag; CI Fix #1204

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Set Producer C SDK to a Release Tag; CI Fix #1204

merged 11 commits into from
Oct 10, 2024

Conversation

stefankiesz
Copy link
Contributor

The current version of Producer C SDK is missing a fix for a build issues on Mac.

error: incompatible pointer to integer conversion passing 'PThreadData' (aka 'struct __ThreadData *') to parameter of type 'UINT64' (aka 'unsigned long long') [-Wint-conversion]
   81 |                             if (stackQueueRemoveItem(pThreadpool->threadList, pThreadData) != STATUS_SUCCESS) {
      |                                                                               ^~~~~~~~~~~
/amazon-kinesis-video-streams-producer-sdk-cpp/dependency/libkvscproducer/kvscproducer-src/dependency/libkvspic/kvspic-src/src/utils/include/com/amazonaws/kinesis/video/utils/Include.h:591:59: note: passing argument to parameter here


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stefankiesz stefankiesz changed the title Switch Producer C SDK Tag to master to Stay Up to Date with Latest Fixes Set Producer C SDK to a Release Tag; CI Fix Oct 9, 2024
@sirknightj sirknightj changed the base branch from master to develop October 10, 2024 17:39
unicornss
unicornss approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@unicornss unicornss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GIT_TAG v1.5.3

@sirknightj sirknightj merged commit 79349c2 into develop Oct 10, 2024
14 checks passed
@sirknightj sirknightj mentioned this pull request Oct 10, 2024
Merged
@sirknightj sirknightj deleted the update-producer-c-version branch October 10, 2024 17:58
sirknightj added a commit that referenced this pull request Oct 10, 2024
@sirknightj @stefankiesz
Release v3.4.2 (#1207)
7acf272 
* Set Producer C SDK to a Release Tag; CI Fix (#1204)

* Update libkvscproducer-CMakeLists.txt

* Update libkvscproducer-CMakeLists.txt

* Shorten Windows CI path

* Move repo to the new location in CI

* Fix the path

* Update ci.yml

* Fix path

* Update ci.yml

* Update ci.yml

* Update ci.yml

* Bump Mac runner image from 12 to 13

* Bump the version from 3.4.1 to 3.4.2 (#1206)

---------

Co-authored-by: Stefan Kieszkowski <85728496+stefankiesz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirknightj sirknightj sirknightj approved these changes

@unicornss unicornss unicornss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefankiesz @sirknightj @unicornss