Fix DDB Retain policies #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - do you think it's worth including a reference to the issue in a comment in the template? just so we know why it's like it is in future? I'm happy either way though so feel free to merge as-is |
HieronymusLex
previously approved these changes
Mar 1, 2020
|
Ok @HieronymusLex, updated including link to issue. |
HieronymusLex
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
During aws-cloudformation/cloudformation-coverage-roadmap#43 I actually broke the template because I wasn't aware of this: https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/162
Unfortunately there is no clean solution to the problem apart from duplicating resources and using conditions. Now I tested it and it works.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.